Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47990/1/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/1/src/soc/intel/common/block/... PS1, Line 251: /*
Ack
done
https://review.coreboot.org/c/coreboot/+/47990/1/src/soc/intel/common/block/... PS1, Line 278: Program obtained ext_bios_size in SPI_BAR_CONTROL
Ack
done
https://review.coreboot.org/c/coreboot/+/47990/1/src/soc/intel/common/block/... PS1, Line 284: dmi_enable_gpmr
Agree, I will restructure this.
Done
https://review.coreboot.org/c/coreboot/+/47990/1/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi_def.h:
https://review.coreboot.org/c/coreboot/+/47990/1/src/soc/intel/common/block/... PS1, Line 12: #define SPI_CFG_BAR1 0xe0 /* SPI BAR1 MMIO */
please, no space before tabs
done