Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37234 )
Change subject: lib/coreboot_table: Add CBMEM_ID_VBOOT_WORKBUF pointer to coreboot table ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37234/2/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/37234/2/src/lib/coreboot_table.c@a2... PS2, Line 224: vboot_get_workbuf You should now make vboot_get_workbuf local (static) to its file because it is no longer needed anywhere else (and there shouldn't be any need to access the workbuffer directly in the future).
https://review.coreboot.org/c/coreboot/+/37234/2/src/lib/coreboot_table.c@33... PS2, Line 335: #if CONFIG(VBOOT) I don't think you need to guard this, other Kconfig-dependent stuff (e.g. TIMESTAMP) isn't guarded either. It will just omit the pointer if it doesn't find it.