Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Matt Papageorge, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55237 )
Change subject: soc/amd/common/fsp/pci: Add size field to PCIe interrupt routing HOB
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55237/comment/b483784d_ea8eddd8
PS3, Line 18: Change
Add a Cq-depend: chrome-internal:3889619
File src/soc/amd/common/block/include/amdblocks/amd_pci_util.h:
https://review.coreboot.org/c/coreboot/+/55237/comment/da92f478_4e3b8708
PS3, Line 55: struct pci_routing_info_hob {
: uint32_t num_of_entries;
: struct pci_routing_info routing_table[];
: } __packed;
:
Can you move this struct into pci_routing_info.c. It's an implementation detail of FSP.
File src/soc/amd/common/fsp/pci/pci_routing_info.c:
https://review.coreboot.org/c/coreboot/+/55237/comment/9c9b6746_ecab754f
PS3, Line 33: d
u?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaafae304f04a5f26d75a41a6d6fcb4ee69954d20
Gerrit-Change-Number: 55237
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Jun 2021 21:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment