Attention is currently required from: Matt DeVillier.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74233 )
Change subject: mb/google/brya: Compile gpio.c in SMM
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74233/comment/f28cd0c5_df6aa299
PS1, Line 9: smm-y += gpio.c
would it make sense to make this conditional on the config option?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If049cba98f13f060807058029306dcad2ada2d49
Gerrit-Change-Number: 74233
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 20:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment