Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33867 )
Change subject: mb/lenovo: Add Lenovo Thinkpad Helix ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/Kconfig File src/mainboard/lenovo/helix/Kconfig:
PS1: Configure the following options: - MAINBOARD_VENDOR - SUBSYSTEM_VENDOR_ID - SUBSYSTEM_DEVICE_ID - PXE_ROM_ID - CBFS_SIZE
https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/Kconfig@1... PS1, Line 11: select MAINBOARD_HAS_LIBGFXINIT # FIXME: check this Extract VBT from vendor bios and add INTEL_GMA_HAVE_VBT here. Make sure to name it 'data.vbt'.