Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40024 )
Change subject: google/chromeec: Add USB MUX Interrupt
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40024/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40024/2//COMMIT_MSG@10
PS2, Line 10: Adding in the Q1C
Add the Q1C
https://review.coreboot.org/c/coreboot/+/40024/2//COMMIT_MSG@11
PS2, Line 11: so the Kernel can properly receive and configure USB devices
Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/40024/2//COMMIT_MSG@14
PS2, Line 14: buld_packages
build_packages
https://review.coreboot.org/c/coreboot/+/40024/2//COMMIT_MSG@15
PS2, Line 15: extcon
What does that mean?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3a2f829a295f090a03e72e12f19ecc5bb724952
Gerrit-Change-Number: 40024
Gerrit-PatchSet: 2
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Thu, 02 Apr 2020 21:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment