Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35086 )
Change subject: [TESTONLY] devicetree: Remove weak declarations for ops
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35086/4/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/35086/4/util/sconfig/main.c@951
PS4, Line 951: if (strstr(chip->name_underscore, "cpu_") == chip->name_underscore) {
Could you please add a comment here about why cpu_ is special?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb783e2f733d5c65c615e5c1879e3e4c7a83e049
Gerrit-Change-Number: 35086
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 20:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment