Attention is currently required from: Jason Glenesk, Raul Rangel.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50343 )
Change subject: mb/amd/majolica: Add chromeos support
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
...otherwise +2!
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/50343/comment/f069fa69_6ed21cd0
PS2, Line 48:
I'm a little surprised you didn't need LP_DEFCONFIG_OVERRIDE. I wonder if the Depthcharge build is smarter now and we no longer need that for kahlee and zork. BTW what version of DC did you build with? It wouldn't surprise me if coreboot's "stable" version is pretty old now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43f0c6e33649332057f41f8813a86571b06032f1
Gerrit-Change-Number: 50343
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Tue, 09 Feb 2021 01:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment