Attention is currently required from: Ravi kumar, Shelley Chen, Paul Menzel, Ravi Kumar Bokka. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support ......................................................................
Patch Set 24:
(3 comments)
File payloads/libpayload/configs/config.herobrine:
https://review.coreboot.org/c/coreboot/+/45206/comment/c3fa25be_d4d2751b PS6, Line 5: CONFIG_LP_SC7280_SERIAL_CONSOLE=y
This changes addressed below gerrit: […]
Well, please don't add things in one patch here only to remove it in the next patch down the road again. Rearrange the patch train so the right things are added in the right place from the start.
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/482d55d2_eb3aafc2 PS6, Line 40: default 0xa
can i use below for disable EC […]
Shelley, can you help figure out which QUP number the EC and TPM are connected to on Herobrine so we can put the right values in here right away? (Just tell Ravi which pins they're connected to, he should be able to figure out the QUP number from that.)
File src/mainboard/google/herobrine/Kconfig.name:
PS24: This should be using a similar USE_QC_BLOBS wrapper as is now in trogdor/Kconfig.name.