Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32281 )
Change subject: soc/intel/../../cpu: Helper function to set IA32_PERF_CTL (0x199) MSR
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32281/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32281/1//COMMIT_MSG@7
PS1, Line 7: soc/intel/../../cpu: Helper function to set IA32_PERF_CTL (0x199) MSR
Please make it a statement:
Add helper function …
The prefix does not need to match the directory structure. Maybe:
soc/intel/cpulib: Factor out IA32_PERF_CTL (0x199) MSR code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212daa61aa11191dd832630461b517d3dbedd6e1
Gerrit-Change-Number: 32281
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 13:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment