Attention is currently required from: Martin Roth, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51948 )
Change subject: soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
My preference is to remove the brackets around the single statement, like Jenkins suggest, but I'm n […]
i still consider removing those a bad idea. sure, it's not in line with what Linux does, but that's the one thing i rather strongly disagree with the Linux coding style
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cb36addcf0202cd56ce99e610a13d6d230bc981
Gerrit-Change-Number: 51948
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Comment-Date: Wed, 31 Mar 2021 21:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment