Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37247 )
Change subject: mb/google/octopus: Create Lick variant ......................................................................
Patch Set 11: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... File src/mainboard/google/octopus/Kconfig:
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... PS11, Line 124: default y if BOARD_GOOGLE_LICK Lick is a new and individual FW variant and it's board always has DRAM part number in CBI. As a result, we don't need it.
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... PS11, Line 135: default 255 if BOARD_GOOGLE_LICK Same reason as above, we don't need it.
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/lick/gpio.c:
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... PS11, Line 4: 2018 2019 and same for others.
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... PS11, Line 55: return c; just "return default_override_table"? so no necessary for "const struct pad_config *c;"
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/lick/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... PS11, Line 82: register "generic.hid" = ""WCOM50C1"" Is there a plan for stylus / pen?
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/lick/variant.c:
https://review.coreboot.org/c/coreboot/+/37247/11/src/mainboard/google/octop... PS11, Line 21: If we only have one sku then variant.c can be deleted.