Attention is currently required from: Angel Pons. Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: [WIP] mb/asus/sklkbl_h: Add base for Asus Skylake Boards ......................................................................
Patch Set 15:
(8 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/48648/comment/3afcfae8_9da41f34 PS4, Line 16: Finish the overridetree
Would it make sense to rather not define a global devicetree and overridetrees for the variants but […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/48648/comment/8ea51acf_e6adcfc4 PS9, Line 13: - Correct UART Output (Output seems to have wrong BAUD,
EDIT: Just received insight to the correct datasheet
Done
File src/mainboard/asus/h110t/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48648/comment/7e0eaf1f_a92025c1 PS1, Line 99: register "PcieRpClkReqSupport[0]" = "1"
Ack
Done
File src/mainboard/asus/sklkbl_h/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48648/comment/bcadece1_1d7c3af6 PS12, Line 7: register "SaGv" = "SaGv_Enabled"
Only matters for ULT, remove.
Done
https://review.coreboot.org/c/coreboot/+/48648/comment/2feaf304_b8802017 PS12, Line 13: register "s0ix_enable" = "1"
Remove, S0ix can cause issues and only makes sense on mobile platforms anyway
Done
File src/mainboard/asus/sklkbl_h/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/48648/comment/7fbd0827_df1210ec PS12, Line 25: #include "acpi/dptf.asl" // TODO Is DPTF meant for desktop boards as well?
I don't think so. […]
Done
File src/mainboard/asus/sklkbl_h/fadt.c:
https://review.coreboot.org/c/coreboot/+/48648/comment/33bb7cd3_54fcdd51 PS12, Line 8: fadt->preferred_pm_profile = PM_DESKTOP;
Shouldn't be needed
Done
File src/mainboard/asus/sklkbl_h/variants/h110t/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48648/comment/7b26302d_b94de375 PS12, Line 20: register "SendVrMbxCmd" = "2"
If you copied this from another board, try without. I really doubt this applies to your board.
Done