Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47700 )
Change subject: mb/google/zork: update DRAM table for dirinboz
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47700/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/47700/1/src/mainboard/google/zork/v...
PS1, Line 18: H5ANAG6NCJR-XNC
Why wouldn't we want to set a fixed ID for this? Note that this isn't a complaint, I'm just not com […]
The tool will auto assign, possibly reusing an existing ID. We only set fixed id for parts that were assigned before the tool was working.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6f26a7b8d014493f4a256b328bee7ad3bf3c2b9
Gerrit-Change-Number: 47700
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Nov 2020 19:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment