Attention is currently required from: Julius Werner, Kapil Porwal, Paul Menzel, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765?usp=email )
Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/74765/comment/18ea8e12_b85b3eb0 :
PS7, Line 310: #if !CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD)
we don't need the guarding IMO
https://review.coreboot.org/c/coreboot/+/74765/comment/d08ef101_e0385f92 :
PS7, Line 311: send_cse_eop_with_late_finalize
```
static void send_cse_eop_with_late_finalize(void *unused)
{
if (CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD))
return;
if (is_cse_eop_supported())
do_send_end_of_post(true);
if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE) ||
CONFIG(SOC_INTEL_CSE_SEND_EOP_ASYNC))
cse_late_finalize();
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74765?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523
Gerrit-Change-Number: 74765
Gerrit-PatchSet: 7
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 17 Oct 2023 05:05:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment