Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45939 )
Change subject: fw_config: Convert fw_config to a 64-bit field
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45939/2/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/45939/2/util/sconfig/main.c@406
PS2, Line 406: /* Check that field is within 64 bits. */
google_chromeec_cbi_get_fw_config() composes 2 seemingly […]
But FW_CONFIG doesn't have to come from the chrome EC, it can also be sourced from a file in CBFS (FW_CONFIG_SOURCE_CBFS). There could be other sources in the future too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f2065d347eafa0ef7b346caeabdc3b626402092
Gerrit-Change-Number: 45939
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 15:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment