[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Select USE_LEGACY_8254_TIMER

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34709 )

Change subject: soc/intel/common: Select USE_LEGACY_8254_TIMER
......................................................................

Patch Set 2:

(2 comments)
> Patch Set 2:
>
> (4 comments)

https://review.coreboot.org/c/coreboot/+/34709/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34709/2//COMMIT_MSG@9 
PS2, Line 9: Always select USE_LEGACY_8254_TIMER if we know we have to.
This patchset changes default of USE_LEGACY_8254_TIMER to Y unconditional.
Shouldn't this line be removed.

https://review.coreboot.org/c/coreboot/+/34709/2/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/34709/2/src/device/Kconfig@89 
PS2, Line 89: 	select USE_LEGACY_8254_TIMER if SOC_INTEL_COMMON_BLOCK
> Option ROMs use the 8254 PIT instead of HPET, TSC or ACPI PM timer as you need to switch to protecte […]

Should this be enabled for VGA Oprom only? Or for all Oproms?