Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36093 )
Change subject: mb/lenovo/x200: Add ThinkPad X301 as a variant
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36093/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36093/4//COMMIT_MSG@25
PS4, Line 25:
: TODO: repurpose and/or rename flag H8_DOCK_EARLY_INIT (introduced in
: CB:4294 ) for h8-using devices without a dock.
For the moment just adding an empty function in ramstage is fine, but it could be done in a followup […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6a6059ccf15dd2e43ed4fc490c1d3c36aa1e817
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 7
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Comment-Date: Sun, 20 Oct 2019 09:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment