11 Apr
2019
11 Apr
'19
2:57 a.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27483 )
Change subject: sdm845: Add SPI QUP driver ......................................................................
Patch Set 46:
(1 comment)
https://review.coreboot.org/#/c/27483/46/src/soc/qualcomm/sdm845/include/soc... File src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h:
https://review.coreboot.org/#/c/27483/46/src/soc/qualcomm/sdm845/include/soc... PS46, Line 203: union proto_rx_trans_len {
I am not sure whether I get your suggestion correctly. […]
Okay, I think I didn't read this closely enough last time... if it's TX for UART but RX for I2C and SPI, I agree a union is nice to make it more clear.
--
To view, visit https://review.coreboot.org/c/coreboot/+/27483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54
Gerrit-Change-Number: 27483
Gerrit-PatchSet: 46
Gerrit-Owner: T.Michael Turney tturne@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: T Michael Turney mturney@codeaurora.org
Gerrit-Reviewer: T.Michael Turney tturne@codeaurora.org
Gerrit-Reviewer: Vin Kamath vink@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 11 Apr 2019 00:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Akash Asthana akashast@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment