Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35409 )
Change subject: arch/arm: Allow program loading of Linux kernels ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c File src/arch/arm/boot.c:
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c@26 PS2, Line 26: case CBFS_TYPE_FIT: /* Flattened image tree */
You also need a dcache_mmu_disable() here, and an "msr cpsr_cxf, #0xd3" in assembly (to switch from […]
Done
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c@27 PS2, Line 27: if (CONFIG(PAYLOAD_FIT_SUPPORT)) {
I'm not sure 3 instructions need to be compile-time guarded for space...
Done
https://review.coreboot.org/c/coreboot/+/35409/3/src/arch/arm/boot.c File src/arch/arm/boot.c:
https://review.coreboot.org/c/coreboot/+/35409/3/src/arch/arm/boot.c@41 PS3, Line 41: * here on!
Fits in 96 characters?
Done
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c File src/arch/arm/boot.c:
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c@19 PS4, Line 19: "eor r0, r0\n\t"
nit: This is an x86ism, I think mov r0, #0 is much more readable (and the same instruction length on […]
Done