build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29645 )
Change subject: mb/google/octopus: Set IOSSTATE to 9 for interrupt pins ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variant... PS1, Line 107: PAD_CFG_GPI_APIC_IOS(GPIO_212, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* Touch Panel Int */ line over 80 characters
https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variant... PS1, Line 109: PAD_CFG_GPI_APIC_IOS(GPIO_214, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* P_SENSOR_INT_L */ line over 80 characters
https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variant... PS1, Line 201: PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_137 -- HP_INT_ODL */ line over 80 characters
https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variant... PS1, Line 202: PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */ line over 80 characters
https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variant... PS1, Line 203: PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */ line over 80 characters