9 Jan
2020
9 Jan
'20
11:57 a.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )
Change subject: src/mainboard: remove MMIO macros ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37738/18/src/mainboard/amd/thatcher... File src/mainboard/amd/thatcher/romstage.c:
https://review.coreboot.org/c/coreboot/+/37738/18/src/mainboard/amd/thatcher... PS18, Line 52: outb(0xea, 0xcd6); : outb(0x1, 0xcd7); pm_write8(0xea, 0x1); ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583034ef0b0ed3e5a5e3dd680c57728ec5efbc8f
Gerrit-Change-Number: 37738
Gerrit-PatchSet: 18
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jan 2020 18:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment