[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake/Kconfig: Don't have all variants select SOC_INTE...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33559 )

Change subject: soc/intel/cannonlake/Kconfig: Don't have all variants select SOC_INTEL_CANNONLAKE
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33559/5/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/33559/5/src/soc/intel/cannonlake/Kconfig@1 
PS5, Line 1: config SOC_INTEL_COMMON_CANNONLAKE_BASE
Reusing the name might confuse people (and downstream code), please
find a better one (maybe just drop _COMMON or _BASE?).