[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch: Allow variants to not necessarily be laptops

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )

Change subject: mb/google/hatch: Allow variants to not necessarily be laptops
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG@14 
PS3, Line 14: the The
> double "the"

Done

https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... 
PS3, Line 29: 	select SYSTEM_TYPE_LAPTOP
> Maybe select BOARD_GOOGLE_BASEBOARD_HATCH here, and drop it from most entries in Kconfig. […]

I could do that however I want to give myself some room to maneuver here until the requirements are clarified. I'll follow up with a change if that seems like a reasonable direction as that seems like a good idea to me.