Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42849 )
Change subject: ACPI GNVS: Replace uses of smm_get_gnvs() ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42849/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42849/4/src/southbridge/intel/i8280... PS4, Line 13: /* For qemu/x86-q35 to build properly. */
is there a better way for this?
I did not really plan on solving SMM_ASEG + GNVS combination for QEMU.
Q35 was with broken i82801ix APM_CNT_GNVS_UPDATE anyways, so this is not regression.
https://review.coreboot.org/c/coreboot/+/42849/4/src/southbridge/intel/i8280... PS4, Line 64: if (gnvs && gnvs->smif) Followup handles qemu-q35 here with
CONFIG(SMM_TSEG) && gnvs->smif
I quess I could have done that here already.