[coreboot-gerrit] [S] Change in coreboot[main]: amdfwtool: Add combo new layout for new family

[Maximilian Brune (Code Review)]

Attention is currently required from: Bao Zheng.

Maximilian Brune has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84233?usp=email )

Change subject: amdfwtool: Add combo new layout for new family
......................................................................

Patch Set 10:

(1 comment)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/84233/comment/c54520c1_33693706?usp... :
PS10, Line 1585: static bool needs_new_combo_layout(enum platform soc_id)
               : {
               : 	return needs_ish(soc_id);
               : }
I am a bit confused. According to this the "new combo layout" implies that we need an ISH. An ISH on the other implies that we are using the recovery a/b flash layout (as is written in `data_parse.c`). So `new_combo_layout` implies `recovery_ab` (transitive property). Which means we don't need the combo layout property right? We can just check if we have a recovery_ab layout.