Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian. Hello build bot (Jenkins), Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52801
to look at the new patch set (#2).
Change subject: mb/google/guybrush: Fix S0i3/S3 GPIO configuration ......................................................................
mb/google/guybrush: Fix S0i3/S3 GPIO configuration
Using PAD_WAKE is actually wrong. The wake bits are only supposed to be set when using the GPIO controller to wake the system. Coreboot's current architecture relies on using GPEs to wake the system.
BUG=b:186011392 TEST=Wake system from S0i3 with EC and see GPE 3 increment.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: If7f9d2c13503c01fb9d834c436dac723f2c3b24c --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/52801/2