Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44158 )
Change subject: mb/google/zork: Use dev_nested_path for dmic gpio update ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@9 PS1, Line 9: gpio machine DMIC GPIO for ACP machine device
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 16: acp_machine_path This can live within update_dmic_gpio().
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 55: struct : drivers_i2c_generic_config * cfg; struct acpi_gpio *gpio; Unrelated change.
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 65: Unrelated change. Not required.
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 80: void static void
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 82: struct Move to next line.
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 83: struct acpi_gpio *gpio; Move to next line.
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 83: No space after *
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 101: gpio = &cfg->dmic_select_gpio; Move to next line.