Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39114 )
Change subject: mb/google/dedede: Add GPIO list
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39114/3/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39114/3/src/mainboard/google/dedede...
PS3, Line 100: /* C0 : RAM_STRAP_0 */
: PAD_NC(GPP_C0, NONE),
: /* C1 : GPP_C1 */
: PAD_NC(GPP_C1, NONE),
: /* C2 : GPP_C2 */
: PAD_NC(GPP_C2, NONE),
: /* C3 : RAM_STRAP_1 */
: PAD_NC(GPP_C3, NONE),
: /* C4 : RAM_STRAP_2 */
: PAD_NC(GPP_C4, NONE),
: /* C5 : RAM_STRAP_3 */
: PAD_NC(GPP_C5, NONE),
Will rebase based on the recently merged changes, […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5293536f66a6b08c9c2d2a6281684755a0c0b1b3
Gerrit-Change-Number: 39114
Gerrit-PatchSet: 7
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Mar 2020 18:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-MessageType: comment