Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42553 )
Change subject: mb/google/hatch: Make puff and variants share common dptf.asl
......................................................................
Patch Set 1:
Patch Set 1:
These are reasonably-likely to diverge over time. Is it really worth merging them now?
See commit msg. The divergence can be captured by a few pre-processor #define's. I think we shouldn't let this run away from us ideally as this really should be done in devicetree imho however this is the next best solution to avoid hard coded ASL spiraling out of control.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35fa1e152adb5f04fb6ef1bd2448376cf9f37980
Gerrit-Change-Number: 42553
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 04:01:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment