Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45306 )
Change subject: trogdor: Move EN_PP3300_DX_EDP for Coachz ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Do we still want to support TROGDOR_REV0?
Unfortunately, I think the answer is yes for now. We're still low on hardware and I think people are still using old trogdor-rev0 boards out there. I actually still use mine, too, since it's hooked up to my PC at work and I haven't been able to go in and switch to newer hardware there.
https://review.coreboot.org/c/coreboot/+/45306/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45306/1//COMMIT_MSG@12 PS1, Line 12: Pin 30 is now : used for a new camera reset GPIO Apparently pin 30 was the MIPI camera on some reference board? Is it like the modem where the code that runs on the camera processor itself hardcodes its GPIOs and therefor is hard to change? ...or maybe someone didn't realize that it was just a GPIO. Doh.