Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41393 )
Change subject: util: add a tool to dump and insert MEC1322 firmware ......................................................................
Patch Set 3:
(1 comment)
Patch Set 1:
Nit pick: did you build with clang?
mec1322.c:65:35: warning: format specifies type 'char' but the argument has type 'int' [-Wformat] printf("SPI clock = %hhd MHz\n", SPI_CLOCK_LIST[hdr->spi_clk]); ~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ %d
Fixed.
https://review.coreboot.org/c/coreboot/+/41393/1/util/mec1322/Makefile File util/mec1322/Makefile:
https://review.coreboot.org/c/coreboot/+/41393/1/util/mec1322/Makefile@1 PS1, Line 1: ## This file is part of the coreboot project. : ##
remove
Done