Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33775 )
Change subject: arch/x86: Adjust size of postcar stack ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33775/4/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/romstage.c:
https://review.coreboot.org/#/c/33775/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 17: #include <arch/cpu.h> You do not need this include anymore since you have removed the define for the default stack size in this patch set. If you have kept it for the prototype (in order to avoid nested includes) than you should add it for all the other files which use postcar_frame_init() and miss this include to be consisten:
src/northbridge/intel/i440bx/ram_calc.c src/northbridge/intel/pineview/ram_calc.c src/soc/intel/broadwell/romstage/romstage.c src/soc/intel/cannonlake/romstage/romstage.c src/soc/intel/denverton_ns/romstage.c src/soc/intel/icelake/romstage/romstage.c src/soc/intel/quark/romstage/fsp2_0.c
https://review.coreboot.org/#/c/33775/4/src/mainboard/emulation/qemu-q35/rom... File src/mainboard/emulation/qemu-q35/romstage.c:
https://review.coreboot.org/#/c/33775/4/src/mainboard/emulation/qemu-q35/rom... PS4, Line 17: #include <arch/cpu.h> Same here.