Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44471 )
Change subject: soc/intel/common/gpio_defs: Remove incorrent GPO macro
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44471/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44471/2//COMMIT_MSG@9
PS2, Line 9: GPIO Driver mode is used for configuration interrupt routing for
: external devices through GPI. But there is no point in configuring
: this for GPO.
do we have any datasheet reference here? I'm still unsure about this driver mode...
GpioIo in ACPI seems to be valid for outputs, too, where driver mode can (shall?) be set according to FSP (3rdparty/fsp/CometLakeFspBinPkg/CometLake1/Include/GpioConfig.h for example)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74c318897647836f4604a937543254f44b470433
Gerrit-Change-Number: 44471
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 16 Aug 2020 10:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment