Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62591 )
Change subject: mb/google/hatch/scout: Add i2c HID driver ......................................................................
mb/google/hatch/scout: Add i2c HID driver
Add HID driver for i2c-1 for Ilitek touchscreen.
BRANCH=None BUG=b:187289163 TEST=Build and flash coreboot; confirm an entry for hidraw for I2C-1 for Ilitek touchscreen.
Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Signed-off-by: Rehan Ghori rehang@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/62591 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/hatch/variants/scout/gpio.c M src/mainboard/google/hatch/variants/scout/overridetree.cb 2 files changed, 17 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/scout/gpio.c b/src/mainboard/google/hatch/variants/scout/gpio.c index 218d3db..5515436 100644 --- a/src/mainboard/google/hatch/variants/scout/gpio.c +++ b/src/mainboard/google/hatch/variants/scout/gpio.c @@ -66,6 +66,8 @@ PAD_CFG_GPI_APIC(GPP_D14, NONE, PLTRST, LEVEL, INVERT), /* D15 : USI_RST_L */ PAD_CFG_GPO(GPP_D15, 1, DEEP), + /* D16 TOUCH_INT */ + PAD_CFG_GPI_IRQ_WAKE(GPP_D16, NONE, PLTRST, LEVEL, INVERT),
/* E2 : Not connected */ PAD_NC(GPP_E2, NONE), diff --git a/src/mainboard/google/hatch/variants/scout/overridetree.cb b/src/mainboard/google/hatch/variants/scout/overridetree.cb index 1312966..8e6bc77 100644 --- a/src/mainboard/google/hatch/variants/scout/overridetree.cb +++ b/src/mainboard/google/hatch/variants/scout/overridetree.cb @@ -381,7 +381,21 @@ device pci 15.0 off # RFU - Reserved for Future Use. end # I2C #0 - device pci 15.1 on end # I2C #1, USI (Touch screen) + device pci 15.1 on # I2C #1, USI (Touch screen) + chip drivers/i2c/hid + register "generic.hid" = ""ILTK0001"" + register "generic.desc" = ""ILITEK Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "600" + register "generic.wake" = "GPE0_DW2_16" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 41 on end + end + end device pci 15.2 on end # I2C #2, SCALER device pci 15.3 on end # I2C #3, TPU device pci 16.0 on end # Management Engine Interface 1