Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30931 )
Change subject: soc/intel/denverton_ns: Allow using FSP repo ......................................................................
Patch Set 3:
(1 comment)
There's a reference to vendorcode/ in denverton_ns/Makefile.inc that should be disabled in case of FSP_USE_REPO.
https://review.coreboot.org/#/c/30931/3/src/soc/intel/denverton_ns/Kconfig File src/soc/intel/denverton_ns/Kconfig:
https://review.coreboot.org/#/c/30931/3/src/soc/intel/denverton_ns/Kconfig@8... PS3, Line 88: default "3rdparty/fsp/DenvertonNSFspBinPkg/FspBin/DenvertonNSFsp.fd" These are used in drivers/intel/fsp2_0/. So their declaration, dependencies and prompts should move there too. Only the defaults should be overridden here. Actually in case of FSP_USE_REPO, they shouldn't have a prompt, should they?
Overriding defaults for something with prompts/ dependencies is delicate, though. Please test.