Isaac Christensen (isaac.christensen@se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6854
-gerrit
commit e9b20c10cb1293ba2b7ce97820e980c67807919b Author: Julius Werner jwerner@chromium.org Date: Thu Oct 17 14:31:36 2013 -0700
libpayload: usbhid: Fix typo on descriptor parsing
Forgot an asterisk and everything goes to hell. Sorry about that.
Change-Id: I6b2503ca3ea0f80d4e4e5d8b8c0e986fec5db2c9 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://chromium-review.googlesource.com/173587 Reviewed-by: Stefan Reinauer reinauer@google.com Commit-Queue: David James davidjames@chromium.org (cherry picked from commit 2a357560a697b56cc6022a4dd3dda47b33568d83) Signed-off-by: Isaac Christensen isaac.christensen@se-eng.com --- payloads/libpayload/drivers/usb/usbhid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/drivers/usb/usbhid.c b/payloads/libpayload/drivers/usb/usbhid.c index 7ae40a8..74b6d5d 100644 --- a/payloads/libpayload/drivers/usb/usbhid.c +++ b/payloads/libpayload/drivers/usb/usbhid.c @@ -452,7 +452,7 @@ usb_hid_init (usbdev_t *dev) hid_descriptor_t *desc = malloc(sizeof(hid_descriptor_t)); if (!desc || get_descriptor(dev, gen_bmRequestType( device_to_host, standard_type, iface_recp), - 0x21, 0, desc, sizeof(*desc)) != sizeof(desc)) { + 0x21, 0, desc, sizeof(*desc)) != sizeof(*desc)) { usb_debug ("get_descriptor(HID) failed\n"); usb_detach_device (dev->controller, dev->address); return;