Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35960 )
Change subject: libpayload: Add uart/serial driver support for trogdor
......................................................................
Patch Set 35:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver...
File payloads/libpayload/drivers/serial/qcom_qupv3_serial.c:
https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver...
PS35, Line 314: if (data == 0xa)
Why is this data special?
https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver...
PS35, Line 316: uart_qupv3_tx_byte(data);
If you want:
uart_qupv3_tx_byte((data == 0xa) ? 0xd : data);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5be3904298cd88c60dbc6d8d662beeede2abe442
Gerrit-Change-Number: 35960
Gerrit-PatchSet: 35
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 05 Mar 2020 13:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment