[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Set GPIO_RESET to output mode

[Tristan Hsieh (Code Review)]

Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31148 )

Change subject: google/kukui: Set GPIO_RESET to output mode
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31148/1/src/mainboard/google/kukui/chromeos.... 
File src/mainboard/google/kukui/chromeos.c:

https://review.coreboot.org/#/c/31148/1/src/mainboard/google/kukui/chromeos.... 
PS1, Line 27: GPIO_RESET
> Can you add GPIO_RESET to the chromeos_gpios below as well? […]

I do think about that when I add this setting.

However, I guess we will keep using ./src/drivers/power/psci.c in depthcharge, instead of ./src/drivers/power/sysinfo.c.
In this case, I think we have to pass the gpio to ATF with param, not to depthcharge with chromeos_gpios[].