Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48858 )
Change subject: soc/intel/apollolake: Fix FSP/GOP display init ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48858/1/src/soc/intel/apollolake/gr... File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/48858/1/src/soc/intel/apollolake/gr... PS1, Line 65: if (CONFIG(RUN_FSP_GOP)) : return; I wonder if this should be done as part of `gma_init` in common/block/graphics/graphics.c as it is applicable to all SoCs and we will keep running into the same problem for platforms selecting RUN_FSP_GOP.
Currently, skylake also has this implementation for graphics_soc_init() and I suspect that it might be broken too.