[coreboot-gerrit] Change in coreboot[master]: commonlib/bsd: Add new CBFS core implementation

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )

Change subject: commonlib/bsd: Add new CBFS core implementation
......................................................................

Patch Set 15: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38421/15/src/commonlib/bsd/cbfs_pri... 
File src/commonlib/bsd/cbfs_private.c:

https://review.coreboot.org/c/coreboot/+/38421/15/src/commonlib/bsd/cbfs_pri... 
PS15, Line 119: 	assert(todo <= sizeof(*dst) - already_read);
> When !FATAL_ASSERTS won't the following read overflow the buffer?

I think the previous code ensures this doesn't happen here. I suggested in earlier patchsets to use assertions when the conditions are checked elsewhere but it's not immediately obvious.