Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31206
Change subject: Kconfig: Add system type entries for convertible and tablet ......................................................................
Kconfig: Add system type entries for convertible and tablet
These are two common system types and in some cases it is important to know when a device is a convertible or a tablet instead of just a laptop.
This change will select the appropriate SMBIOS enclosure type based on the selected system type.
This is important for the Intel Virtual Button driver as it does a check on the SMBIOS enclosure type and only enables the tablet mode events if it is set to convertible: https://patchwork.kernel.org/patch/10236253/
Change-Id: I148ec2329a1dd38ad55c60ba277a514c66376fcc Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/Kconfig 1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/31206/1
diff --git a/src/Kconfig b/src/Kconfig index a069f63..dc960eb 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -335,6 +335,14 @@ default n bool
+config SYSTEM_TYPE_TABLET + default n + bool + +config SYSTEM_TYPE_CONVERTIBLE + default n + bool + config CBFS_AUTOGEN_ATTRIBUTES default n bool @@ -654,11 +662,14 @@ hex depends on GENERATE_SMBIOS_TABLES default 0x09 if SYSTEM_TYPE_LAPTOP + default 0x1e if SYSTEM_TYPE_TABLET + default 0x1f if SYSTEM_TYPE_CONVERTIBLE default 0x03 help System Enclosure or Chassis Types as defined in SMBIOS specification. - The default value is SMBIOS_ENCLOSURE_DESKTOP (0x03) or - SMBIOS_ENCLOSURE_LAPTOP (0x09) if SYSTEM_TYPE_LAPTOP is set. + The default value is SMBIOS_ENCLOSURE_DESKTOP (0x03) but laptop, + convertible, or tablet enclosure will be used if the appropriate + system type is selected.
endmenu