David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34400 )
Change subject: mb/google/hatch/var/kindred: Implement variant_devtree_update() ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/... PS2, Line 33: google_chromeec_cbi_get_sku_id
There is an implementation of get_board_sku() in hatch/mainboard.c. […]
Make it non-static, will show compile error as below. how to fix this error? thanks.
CC ramstage/mainboard/google/hatch/ramstage.o src/mainboard/google/hatch/mainboard.c:26:10: error: no previous prototype for 'get_board_sku' [-Werror=missing-prototypes] uint32_t get_board_sku(void) ^~~~~~~~~~~~~ CC ramstage/lib/b64_decode.o CC ramstage/lib/boot_device.o CC ramstage/lib/bootmem.o cc1: all warnings being treated as errors make: *** [Makefile:357: build-kindred/ramstage/mainboard/google/hatch/mainboard.o] Error 1 make: *** Waiting for unfinished jobs.... * ERROR: sys-boot/coreboot-9999::chromiumos failed (compile phase): * emake failed * * If you need support, post the output of `emerge --info '=sys-boot/coreboot-9999::chromiumos'`, * the complete build log and the output of `emerge -pqv '=sys-boot/coreboot-9999::chromiumos'`. * The complete build log is located at '/build/hatch/tmp/portage/logs/sys-boot:coreboot-9999:20190719-024940.log'.