Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: A common API for loading the blob file ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... File src/soc/mediatek/common/mtlib.c:
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... PS14, Line 21: binary "%s: Failed to load %s.\n", __func__, name
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... PS14, Line 25: memcpy((void *)addr, blob_data, blob_bytes); One question. If we will do mb(), why can't we just use addr?
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... PS14, Line 27: /* Memory barrier to ensure that all firmware code is loaded : * before we release the reset pin. : */ given this is a generic function now maybe:
Memory barrier to ensure data is flushed so we can initiate DMA on return.