Julius Werner has posted comments on this change. ( https://review.coreboot.org/19489 )
Change subject: scarlet/gru: skip usbphy1 setup for Scarlet ......................................................................
Patch Set 3:
(3 comments)
The mainboard code is accessing struct members from the SoC header, Paul, you can't change them independently.
LGTM except for a few nits.
https://review.coreboot.org/#/c/19489/3//COMMIT_MSG Commit Message:
PS3, Line 2: philipchen This should say "Philip Chen". Can you double-check your git config?
PS3, Line 7: scarlet/gru This would be better as "google/gru: ", probably, then you can keep the "Scarlet" at the end.
https://review.coreboot.org/#/c/19489/3/src/mainboard/google/gru/mainboard.c File src/mainboard/google/gru/mainboard.c:
PS3, Line 309: { nit: can remove braces