[coreboot-gerrit] Change in coreboot[master]: [RFC] device: Introduce new method for setting device states

[Tim Wawrzynczak (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Michael Niewöhner, Patrick Rudolph, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )

Change subject: [RFC] device: Introduce new method for setting device states
......................................................................

Patch Set 22:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/52493/comment/c79160d9_88d27d54 
PS22, Line 7: [RFC]
I think everyone likes this enough you can drop the RFC 😊

File src/include/device/devenmap.h:

https://review.coreboot.org/c/coreboot/+/52493/comment/87b1ce73_6bf46af4 
PS22, Line 12: option
what about naming this one `upd` ?

https://review.coreboot.org/c/coreboot/+/52493/comment/c6aba323_b0a98577 
PS22, Line 13: pci_devfn_t
`PCH_DEVFN` and friends are `unsigned int`, *not* `pci_devfn_t`; `PCI_DEV` creates a `pci_devfn_t`... I mess this up all of the time 😊

https://review.coreboot.org/c/coreboot/+/52493/comment/0a2cbe2d_42ebd07c 
PS22, Line 14: hook
maybe `enable_cb` (enable callback) or similar? `hook` seems kinda generic

https://review.coreboot.org/c/coreboot/+/52493/comment/78f587f1_240fa40c 
PS22, Line 18: set_dev_state_by_devicetree
I think the name of this function should include `fsp` or `upd` to make it a little more clear what's going on.