[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add SD card support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )

Change subject: mb/google/dedede: Add SD card support
......................................................................

Patch Set 25: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... 
PS23, Line 284: GPP_G7
> Ack

Thanks for the confirmation, Aamir!

https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... 
PS25, Line 272: NATIVE
I think the reason you are setting this to NATIVE is because the controller would want to pull up to 1.8 or 3.3V depending upon mode? If that understanding is correct, can you please add a comment here?