Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44751 )
Change subject: soc/amd/picasso: copy local info to transfer buf
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44751/4/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/44751/4/src/soc/amd/picasso/psp_ver...
PS4, Line 189: sizeof(buffer_info)
Optional but I think a good idea - While both src and dst happen to be the same type at the moment it is best to be defensive here and do the sizeof the dst or directly the size of the struct type and not the source.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14bc34e6af501240a6f633db3999a7759e88d60b
Gerrit-Change-Number: 44751
Gerrit-PatchSet: 4
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 03:50:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment