Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36445 )
Change subject: emulation/riscv: Don't probe for total DRAM
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36445/1/src/mainboard/emulation/qem...
File src/mainboard/emulation/qemu-riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/36445/1/src/mainboard/emulation/qem...
PS1, Line 58: int "size of DRAM. Run qemu with the argument -m ***M"
Isn't this the main problem? Ensuring the correct arguments are passed to qemu?
Partially, trying to access memory where there is no dram throws in an exception, so probing cannot be done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36445
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4d9fbb727f41436798783a357b3cfb7b64d3edb
Gerrit-Change-Number: 36445
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 30 Oct 2019 13:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment