[coreboot-gerrit] [M] Change in coreboot[main]: soc/amd/common: Support sbin ucode files

[Maximilian Brune (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Raul Rangel.

Maximilian Brune has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )

Change subject: soc/amd/common: Support sbin ucode files
......................................................................

Patch Set 9:

(3 comments)

File src/soc/amd/common/block/cpu/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/68122/comment/fea04cf9_59821a39?usp... :
PS3, Line 19: Function
> I agree, but the problem is that in order to write proper makefile rules we would need to know the n […]

Done

File src/soc/amd/common/block/cpu/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/68122/comment/804eef3f_1e655de0?usp... :
PS9, Line 52: extract-bytes = $(shell echo $(shell od -A n -N $(2) -j $(3) -t $(4) $(1)))
> one of the minor concerns I had with this patch and `od` directly is that we are assuming this alway […]

Done

https://review.coreboot.org/c/coreboot/+/68122/comment/d7c922a7_1ac0dcb1?usp... :
PS9, Line 52: extract-bytes = $(shell echo $(shell od -A n -N $(2) -j $(3) -t $(4) $(1)))
> for consistency, the call to `od` here should probably use the long options format instead of the sh […]

good catch